build: add bundling/build-cjs.ts
#469
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
+ Coverage 46.24% 46.33% +0.08%
==========================================
Files 19 19
Lines 5650 5659 +9
Branches 227 227
==========================================
+ Hits 2613 2622 +9
Misses 3034 3034
Partials 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I like these changes a lot! This is a great stepping stone towards #372
| "test": "deno test --seed=123456 --parallel ./test/", | ||
| "dev": "deno fmt && deno lint && deno task test && deno task check", | ||
| "coverage": "rm -rf ./test/cov_profile && deno task test --coverage=./test/cov_profile && deno coverage --lcov --output=./coverage.lcov ./test/cov_profile", | ||
| "report": "genhtml ./coverage.lcov --output-directory ./test/coverage/ && echo 'Point your browser to test/coverage/index.html to see the test coverage report.'", | ||
| "bundle": "cd bundling && ./bundle-all.sh", | ||
| "bundle-web": "mkdir -p out deno_cache && cd bundling && DENO_DIR=$PWD/../deno_cache deno run --unstable --quiet --allow-net --allow-read --allow-env=DENO_DIR,XDG_CACHE_HOME,HOME,DENO_AUTH_TOKENS --allow-write=../out,$PWD/../deno_cache bundle-web.ts dev ../src/mod.ts", | ||
| "contribs": "deno run --allow-env --allow-read --allow-write=. --allow-net=api.github.com npm:all-contributors-cli" |
There was a problem hiding this comment.
Accidentally removed this while resolving conflicts 🙈 pin to a major release and tighten permission when restoring.
|
Yes, if you forego bundling, and use v2-only |
|
I think we're just going to migrate to JSR and cross-publish the packages to npm so that we can get rid of the build step entirely |
|
Will likely be superseded by #559 |
|
Decided |
Alternative to fromdeno/deno2node#40: reusable script with embedded
compilerOptions. Feel free to revert any changes you don't like.