build: use Deno and deno2node #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dunkan <[email protected]> Co-authored-by: Wojciech Pawlik <[email protected]>
wojpawlik
suggested changes
Nov 17, 2023
wojpawlik
reviewed
Nov 19, 2023
wojpawlik
reviewed
Nov 23, 2023
|
Thank you @dcdunkan @wojpawlik for your feedback on this and previous PRs to bring Deno and deno2node to this repo! Your feedback helped a lot in exploring what works best! Thanks again @dcdunkan for initially starting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look again into it and collected all the things together from #36 and other sources.
Publish to deno.land on version tag via Webhook - done.
This will likely end up being my template for all my Node.js modules.
Do you have any thoughts @dcdunkan @wojpawlik ? (I might have missed things on #36 that didn't went into this so feel free to restate them when you think they are relevant.) When I don't hear from you I will merge this in the coming days. Afterwards I'll look into @grammyjs/stateless-question to do the same.
closes #36