Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out the parsing of BrowserContextOptions and child options #1390

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Move out the parsing of BrowserContextOptions and child options #1390

wants to merge 9 commits into from

Commits on Jun 21, 2024

  1. Desobekify Browser 

    - Moves BrowserContextOptions out of the business logic.
- Sets default options in NewBrowserContext to prevent nil pointer
  issues in the rest of the module. Later, we might think about turning
some of these pointer fields into value types to take advantage of their
zero values.
    @inancgumus
    inancgumus committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3f26d5c View commit details
    Browse the repository at this point in the history

  2. Move out BrowserContextOptions parsing 

    Moves BrowserContextOptions parsing out of the business logic.
    @inancgumus
    inancgumus committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ef173df View commit details
    Browse the repository at this point in the history

  3. Move out geolocation parsing 

    - Separates the parsing of options from their validation. The validation
  logic remains in the business logic while the parsing happens in the
mapping layer.
- Moves geolocation option parsing to the mapping layer.
- Adds a validation function for geolocation.
    @inancgumus
    inancgumus committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b7b8770 View commit details
    Browse the repository at this point in the history

  4. Add ParseCredentials

    @inancgumus
    inancgumus committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3fc7c30 View commit details
    Browse the repository at this point in the history

  5. Use Credentials in SetHTTPCredentials

    @inancgumus
    inancgumus committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0883595 View commit details
    Browse the repository at this point in the history

  6. Add ParseScreen

    @inancgumus
    inancgumus committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0b543b7 View commit details
    Browse the repository at this point in the history

  7. Add ParseViewport

    @inancgumus
    inancgumus committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    cefe214 View commit details
    Browse the repository at this point in the history

  8. Add optionWidth and optionHeight

    @inancgumus
    inancgumus committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    57b9aca View commit details
    Browse the repository at this point in the history

  9. Refactor browser opt parsers to take rt

    @inancgumus
    inancgumus committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    83ac07e View commit details
    Browse the repository at this point in the history