Move out the parsing of BrowserContextOptions and child options
#1390
+341
−266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves BrowserContextOptions out of the business logic. - Sets default options in NewBrowserContext to prevent nil pointer issues in the rest of the module. Later, we might think about turning some of these pointer fields into value types to take advantage of their zero values.
Moves BrowserContextOptions parsing out of the business logic.
- Separates the parsing of options from their validation. The validation logic remains in the business logic while the parsing happens in the mapping layer. - Moves geolocation option parsing to the mapping layer. - Adds a validation function for geolocation.
inancgumus
changed the title
BrowserContextOptions and children parsing
inancgumus
changed the title
BrowserContextOptions and children parsingBrowserContextOptions and child options
inancgumus
force-pushed
the
desobekify/browser
branch
from
3f26d5c
to
2b13ae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves
BrowserContextOptionsand child options parsing out of the business logic.Why?
To decouple sobek from the business logic.
Checklist
Related PR(s)/Issue(s)
#1269