Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New transaction feature #1141

Closed
wants to merge 11 commits into from
Closed

New transaction feature #1141

wants to merge 11 commits into from

Commits on Aug 21, 2023

  1. Test for time 

    Print the time difference for the transaction test to look at latency.
    @danieljbruce
    danieljbruce committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    c5f6954 View commit details
    Browse the repository at this point in the history

  2. running test to see latency improvement 

    We want to see the latency improvement of running the transaction when the previous transaction is specified.
    @danieljbruce
    danieljbruce committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    142ca57 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Try requests with two sets of options 

    Trying options with two different previous transactions.
    @danieljbruce
    danieljbruce committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    39d411c View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Some new transaction tests

    @danieljbruce
    danieljbruce committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c95fe49 View commit details
    Browse the repository at this point in the history

  2. Add more test comments

    @danieljbruce
    danieljbruce committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8d98572 View commit details
    Browse the repository at this point in the history

  3. Add internal change that passes transaction opts 

    This internal change allows the newTransaction and readTime parameters to be passed along to the gapic layer.
    @danieljbruce
    danieljbruce committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c0523e4 View commit details
    Browse the repository at this point in the history

  4. Add tests that explore different edge cases 

    Introduce tests that will explore the use of new transaction with a previous transaction specified
    @danieljbruce
    danieljbruce committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2c30626 View commit details
    Browse the repository at this point in the history

  5. Take some measurements 

    Put some measurements in the test along with the commit hashes to keep track of latency.
    @danieljbruce
    danieljbruce committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5acff76 View commit details
    Browse the repository at this point in the history

  6. Fix the two tests so that they use the previous tx 

    The two tests need the ids from the previous transaction so this typo needs to be fixed
    @danieljbruce
    danieljbruce committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    24cc596 View commit details
    Browse the repository at this point in the history

  7. Another test that runs two transactions 

    Run two transactions one after the other where the transactions have no special options
    @danieljbruce
    danieljbruce committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    e74e2cf View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Add a couple of tests to document new tx 

    Document new transaction edge cases
    @danieljbruce
    danieljbruce committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    9922de8 View commit details
    Browse the repository at this point in the history