Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New transaction feature #1141

Closed

Conversation

danieljbruce
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Print the time difference for the transaction test to look at latency.
We want to see the latency improvement of running the transaction when the previous transaction is specified.
Trying options with two different previous transactions.
This internal change allows the newTransaction and readTime parameters to be passed along to the gapic layer.
Introduce tests that will explore the use of new transaction with a previous transaction specified
Put some measurements in the test along with the commit hashes to keep track of latency.
The two tests need the ids from the previous transaction so this typo needs to be fixed
Run two transactions one after the other where the transactions have no special options
Document new transaction edge cases
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: datastore Issues related to the googleapis/nodejs-datastore API. labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant