Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Prometheus metrics using OTEL #55

Merged
merged 5 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 0 additions & 74 deletions xkafka/middleware/prometheus/consumer_middleware.go

This file was deleted.

58 changes: 0 additions & 58 deletions xkafka/middleware/prometheus/consumer_middleware_test.go

This file was deleted.

3 changes: 0 additions & 3 deletions xkafka/middleware/prometheus/doc.go

This file was deleted.

27 changes: 0 additions & 27 deletions xkafka/middleware/prometheus/metrics.go

This file was deleted.

22 changes: 0 additions & 22 deletions xkafka/middleware/prometheus/metrics_test.go

This file was deleted.

64 changes: 0 additions & 64 deletions xkafka/middleware/prometheus/producer_middleware.go

This file was deleted.

55 changes: 0 additions & 55 deletions xkafka/middleware/prometheus/producer_middleware_test.go

This file was deleted.

25 changes: 0 additions & 25 deletions xkafka/middleware/prometheus/semconv.go

This file was deleted.

3 changes: 3 additions & 0 deletions xprom/doc.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// Package xprom provides a prometheus metrics that follow
// the OpenTelemetry semantic conventions.
package xprom
3 changes: 3 additions & 0 deletions xprom/go.mod
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module github.com/gojekfarm/xtools/xprom

go 1.21
12 changes: 12 additions & 0 deletions xprom/semconv/common.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package semconv

// Server labels.
const (
ServerAddress = "server_address"
ServerPort = "server_port"
)

// Error labels.
const (
ErrorType = "error_type"
)
3 changes: 3 additions & 0 deletions xprom/semconv/doc.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// Package semconv provides standard OpenTelemetry semantic
// conventions for Prometheus metrics.
package semconv
3 changes: 3 additions & 0 deletions xprom/semconv/go.mod
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module github.com/gojekfarm/xtools/xprom/semconv

go 1.21
Loading
Loading