Standardize Prometheus metrics using OTEL #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 98.34% 99.24% +0.89%
==========================================
Files 47 29 -18
Lines 1030 661 -369
==========================================
- Hits 1013 656 -357
+ Misses 17 5 -12 ☔ View full report in Codecov by Sentry. |
witochandra
reviewed
Jul 4, 2024
xprom/xkafkaprom/collector.go
Outdated
| @@ -0,0 +1,230 @@ | |||
| package xkafkaprom | |||
There was a problem hiding this comment.
Should we make the package name simply as xprom/xkafka rather than xprom/xkafkaprom?
There was a problem hiding this comment.
i want to avoid the name conflict while creating and configuring a producer/consumer.
Maybe we can use a convention like xprom* - xpromkafka, xpromdb, xpromsql etc.
There was a problem hiding this comment.
i have noticed this pattern in https://github.com/riverqueue/river
witochandra
approved these changes
Jul 5, 2024
ajatprabha
reviewed
Jul 5, 2024
ajatprabha
approved these changes
Jul 8, 2024
witochandra
approved these changes
Jul 8, 2024
witochandra
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.