Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to jump to definition of external functions defined in the same module #3613

Merged
merged 10 commits into from
Sep 12, 2024
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,10 @@
prelude.
([Surya Rose](https://github.com/GearsDatapacks))

- Fixed a bug where the language server wouldn't let you jump to the definition
of a function with an external implementation defined in the same module.
([Giacomo Cavalieri](https://github.com/giacomocavalieri))

## v1.4.1 - 2024-08-04

### Bug Fixes
Expand Down
225 changes: 221 additions & 4 deletions compiler-core/generated/schema_capnp.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 12 additions & 5 deletions compiler-core/schema.capnp
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ struct ValueConstructor {
}

struct Publicity {
union {
public @0 :Void;
private @1 :Void;
internal @2 :Option(SrcSpan);
}
union {
public @0 :Void;
private @1 :Void;
internal @2 :Option(SrcSpan);
}
}

struct Implementations {
Expand Down Expand Up @@ -141,6 +141,8 @@ struct ValueConstructorVariant {
location @7 :SrcSpan;
documentation @15 :Text;
implementations @18 :Implementations;
externalErlang @20 :Option(External);
externalJavascript @21 :Option(External);
}

record :group {
Expand All @@ -156,6 +158,11 @@ struct ValueConstructorVariant {
}
}

struct External {
module @0 :Text;
function @1 :Text;
}

struct SrcSpan {
start @0 :UInt32;
end @1 :UInt32;
Expand Down
Loading
Loading