Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to jump to definition of external functions defined in the same module #3613

Merged
merged 10 commits into from
Sep 12, 2024

Conversation

giacomocavalieri
Copy link
Member

This PR closes #3610

@giacomocavalieri giacomocavalieri marked this pull request as draft September 11, 2024 15:51
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Few small notes

compiler-core/schema.capnp Outdated Show resolved Hide resolved
compiler-core/src/analyse.rs Outdated Show resolved Hide resolved
compiler-core/src/language_server/engine.rs Outdated Show resolved Hide resolved
compiler-core/src/language_server/tests.rs Outdated Show resolved Hide resolved
@lpil lpil marked this pull request as draft September 12, 2024 15:22
@giacomocavalieri giacomocavalieri marked this pull request as ready for review September 12, 2024 15:48
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@lpil lpil merged commit ac9ed60 into gleam-lang:main Sep 12, 2024
12 checks passed
@giacomocavalieri giacomocavalieri deleted the fix-3610 branch September 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP: "Go to definition" does not work on external functions declared in the same file
2 participants