Improve Error Messages in Test Cases #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/describe |
github-actions
bot
changed the title
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
Refactoring
PR Description:
This PR refactors the error handling in two test cases. The changes include:
PR Main Files Walkthrough:
files:
ownership-chain/e2e-tests/tests/test-create-collection.ts: Refactored the error handling in the test case 'when collection does not exist owner of call should fail'. The error message is now decoded from hexadecimal to a string and the expected error message is updated to 'invalid collection address'.ownership-chain/e2e-tests/tests/test-evolution.ts: Refactored the error handling in the test case 'when asset is minted it should return token uri'. The error message is now decoded from hexadecimal to a string and the expected error message is updated to 'asset does not exist'.