Refactor Mock Implementation in Tests #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
Refactoring
PR Description:
This PR refactors the mock implementation in the tests of the
ownership-chain/precompile/laos-evolution/src/tests.rs
file. The main changes include:PrecompileMockParams
in thehelpers
module to hold the results of different mock methods.impl_precompile_mock_simple!
macro to use thePrecompileMockParams
struct instead of individual variables for each method result.PrecompileMockParams
struct.PR Main Files Walkthrough:
files:
ownership-chain/precompile/laos-evolution/src/tests.rs
: The file contains tests for theownership-chain/precompile/laos-evolution
module. The changes in this file are mainly about refactoring the mock implementation used in the tests. A new structPrecompileMockParams
is introduced in thehelpers
module to hold the results of different mock methods. Theimpl_precompile_mock_simple!
macro is refactored to use this new struct. All the test cases are updated to use the newPrecompileMockParams
struct.