Fixing Mint with External URI Event and Adding Corresponding Tests #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/describe |
github-actions
bot
changed the title
magecnion
requested changes
Oct 30, 2023
magecnion
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
Bug fix, Tests
PR Description:
This PR addresses a bug in the minting process with an external URI event. It modifies the event logging mechanism and adds a new test case to ensure the correct behavior of the minting process. The changes are primarily in the
lib.rsandtests.rsfiles of theownership-chain/precompile/laos-evolutionmodule.PR Main Files Walkthrough:
files:
ownership-chain/precompile/laos-evolution/src/lib.rs: The changes in this file mainly revolve around the minting process with an external URI. The logging mechanism for the minting event has been modified. Instead of using aLogstruct, aLogsBuilderis used to record the event. This change provides a more flexible and comprehensive way to log events. Also, some unused imports have been removed.ownership-chain/precompile/laos-evolution/src/tests.rs: A new test casemint_with_external_uri_should_generate_loghas been added. This test ensures that the minting process with an external URI generates the correct log. The test uses a mock to simulate the minting process and checks the resulting log for correctness.