Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM events can be obtained via RPC-EVM! (integration test?) #118

Closed
tonimateos opened this issue Oct 26, 2023 · 4 comments · Fixed by #126, #128, #129, #130 or #132
Closed

EVM events can be obtained via RPC-EVM! (integration test?) #118

tonimateos opened this issue Oct 26, 2023 · 4 comments · Fixed by #126, #128, #129, #130 or #132
Labels
High Priority Proposed to focus on this when other tasks are present Sprint Candidate Proposed by PO for the very next sprint

Comments

@tonimateos
Copy link
Contributor

tonimateos commented Oct 26, 2023

As a DApp developer on the Evochain I want to get the events of createCollection and MintAsset by using standard web3 tools connected to the RPC endpoint, so that my DApps, which track events, can work

Note: have a look at this code that shows potential issues with current implementation: https://github.com/freeverseio/experiments/tree/master/laos_hardhat

ACCEPTANCE:

  • I can use hardhat to get the events of createCollection and MintAsset
  • If the events could not be queried because of a bug... please update runtime immediately after fixing it (hotfix), since Blackhole will be using this during their current sprint
@tonimateos tonimateos added Sprint Candidate Proposed by PO for the very next sprint High Priority Proposed to focus on this when other tasks are present labels Oct 26, 2023
@tonimateos tonimateos changed the title Integration test to catch EVM events EVM events can be obtained via RPC-EVM! (integration test?) Oct 26, 2023
@tonimateos
Copy link
Contributor Author

tonimateos commented Oct 26, 2023

Note: Integration tests are put in main, but if there is a bug discovered, since this may end up in a hotfix, then branch from last release tag, to avoid merging code that is still developed during the sprint.

@ghost ghost self-assigned this Oct 26, 2023
@ghost
Copy link

ghost commented Oct 26, 2023

  • investigate evm fetch log issue
  • introduce integration testing suite (fork moonbeam's or frontier's) Adding Integration Tests to CI Pipeline #132
  • add test to all existing rpc endpoints
    • createCollection
    • ownerOfCollection
    • tokenURI
    • mintWithExternalURI
    • evolveWithExternalURI

@ghost ghost linked a pull request Oct 26, 2023 that will close this issue
@ghost
Copy link

ghost commented Oct 26, 2023

the linked PR contains a work that can be continued to properly investigate the evm log issue and adding integration testing suite

@asiniscalchi
Copy link
Member

Logs bugs are fixed. v0.3.2 was released and deployed in seldon.

@magecnion magecnion linked a pull request Oct 31, 2023 that will close this issue
@asiniscalchi asiniscalchi self-assigned this Nov 2, 2023
@magecnion magecnion linked a pull request Nov 2, 2023 that will close this issue
@asiniscalchi asiniscalchi removed their assignment Nov 3, 2023
@magecnion magecnion linked a pull request Nov 3, 2023 that will close this issue
@magecnion magecnion removed their assignment Nov 6, 2023
@magecnion magecnion linked a pull request Nov 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment