Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix NewCollection event #128

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix NewCollection event #128

merged 1 commit into from
Oct 27, 2023

Conversation

asiniscalchi
Copy link
Member

No description provided.

@asiniscalchi asiniscalchi changed the base branch from main to v0.3 October 27, 2023 14:12
@asiniscalchi asiniscalchi marked this pull request as ready for review October 27, 2023 14:32
@asiniscalchi
Copy link
Member Author

/describe

@asiniscalchi asiniscalchi merged commit 9ebd1af into v0.3 Oct 27, 2023
6 checks passed
@asiniscalchi asiniscalchi deleted the hotfix/use_data_field branch October 27, 2023 14:38
@asiniscalchi asiniscalchi linked an issue Oct 30, 2023 that may be closed by this pull request
EVM events can be obtained via RPC-EVM! (integration test?) #118
Closed
asiniscalchi added a commit that referenced this pull request Oct 31, 2023
@asiniscalchi
Fixing Mint with External URI Event and Adding Corresponding Tests (#130
aefc48b 
)

* fix NewCollection event (#128)

* test + mint uses data field

* fmt

* refactoring test

* fmt

* removed merge line

* removed code

* unused cast

* back to Bytes

* using ALICE address in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonimateos tonimateos tonimateos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVM events can be obtained via RPC-EVM! (integration test?)
2 participants
@asiniscalchi @tonimateos