Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust contrast ratio on selected disabled checkbox #454

Conversation

JanHamara
Copy link
Contributor

What

Fix the low contrast ratio on selected disabled checkbox

Media

Screenshot 2024-05-31 at 13 48 50

Why

453

Closes #453

How

Use background-element-disabled-default instead of background-element-disabled-faded

@JanHamara JanHamara self-assigned this May 31, 2024
@JanHamara JanHamara changed the title fix: adjust contrast ratio on selected disabled checkbox (#453) fix: adjust contrast ratio on selected disabled checkbox May 31, 2024
@JanHamara JanHamara merged commit b873693 into main May 31, 2024
10 checks passed
@JanHamara JanHamara deleted the 453-contrast-ratio-between-bg-and-checkmark-on-disabled-selected-checkbox-is-too-low branch May 31, 2024 13:08
github-actions bot pushed a commit that referenced this pull request May 31, 2024
### [2.2.2](v2.2.1...v2.2.2) (2024-05-31)

### Bug Fixes

* **checkbox:** change the bg semantic color token ([#454](#454)) ([b873693](b873693))
Copy link
Contributor

🎉 This PR is included in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Contrast ratio between bg and checkmark on disabled selected Checkbox is too low
3 participants