You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We received a report from doc val agents regarding the recent changes related to Wave on the DMT. Upon replacing the deprecated Checkboxes with Wave Checkbox, the doc val agents find it very hard to see which of disabled boxes are checked or not checked (in the non-edit mode in our Dynamic Layouts).
Having to agree, the contrast ratio is indeed waay too low (we use the background-element-disabled-faded token for the background atm, checkmark is white)
The solution is super simple, replacing the current token with usage of background-element-disabled-default, which offers way better contrast ratio. (See below)
Action
This is pretty important to doc val agents, so I will go ahead and open MR immediately 🙂 I have already proposed and reviewed the change with design.
The text was updated successfully, but these errors were encountered:
@freenow/wave
version: 2.2.1Relevant code
What was expected to happen?
Hello fellow maintainers!
We received a report from doc val agents regarding the recent changes related to Wave on the DMT. Upon replacing the deprecated Checkboxes with Wave Checkbox, the doc val agents find it very hard to see which of disabled boxes are checked or not checked (in the non-edit mode in our Dynamic Layouts).
Having to agree, the contrast ratio is indeed waay too low (we use the
background-element-disabled-faded
token for the background atm, checkmark is white)The solution is super simple, replacing the current token with usage of
background-element-disabled-default
, which offers way better contrast ratio. (See below)Action
This is pretty important to doc val agents, so I will go ahead and open MR immediately 🙂 I have already proposed and reviewed the change with design.
The text was updated successfully, but these errors were encountered: