Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrast ratio between bg and checkmark on disabled selected Checkbox is too low #453

Closed
JanHamara opened this issue May 31, 2024 · 1 comment · Fixed by #454
Closed
Assignees
Labels
🔥 Critical To address asap enhancement New feature or request released

Comments

@JanHamara
Copy link
Contributor

  • @freenow/wave version: 2.2.1

Relevant code

&:disabled {
        background-color: ${getSemanticValue('background-element-disabled-default')};
 }

What was expected to happen?

Hello fellow maintainers!

We received a report from doc val agents regarding the recent changes related to Wave on the DMT. Upon replacing the deprecated Checkboxes with Wave Checkbox, the doc val agents find it very hard to see which of disabled boxes are checked or not checked (in the non-edit mode in our Dynamic Layouts).

Having to agree, the contrast ratio is indeed waay too low (we use the background-element-disabled-faded token for the background atm, checkmark is white)

The solution is super simple, replacing the current token with usage of background-element-disabled-default, which offers way better contrast ratio. (See below)

Screenshot 2024-05-31 at 13 48 50

Action

This is pretty important to doc val agents, so I will go ahead and open MR immediately 🙂 I have already proposed and reviewed the change with design.

Copy link
Contributor

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Critical To address asap enhancement New feature or request released
Development

Successfully merging a pull request may close this issue.

1 participant