Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Configure Images portlet into news page template - EXO-65514 - Meeds-io/MIPs#68 #917

Merged
merged 3 commits into from
Aug 23, 2023
Merged

feat: Configure Images portlet into news page template - EXO-65514 - Meeds-io/MIPs#68 #917

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efdf55e
TASK-62301: Create FB experience and update projects versions/depende…
halaya Feb 7, 2023
d1b7908
feat: Add a new Images portlet to display the portlet banner - EXO-65514
IlhemEssaadi Aug 15, 2023
c298c24
fix review
IlhemEssaadi Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packaging/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<parent>
<artifactId>news</artifactId>
<groupId>org.exoplatform.addons.news</groupId>
<version>2.5.x-SNAPSHOT</version>
<version>2.5.x-experience-SNAPSHOT</version>
</parent>
<artifactId>news-packaging</artifactId>
<packaging>pom</packaging>
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</parent>
<groupId>org.exoplatform.addons.news</groupId>
<artifactId>news</artifactId>
<version>2.5.x-SNAPSHOT</version>
<version>2.5.x-experience-SNAPSHOT</version>
<packaging>pom</packaging>
<name>eXo Add-on:: News</name>
<description>News</description>
Expand All @@ -40,7 +40,7 @@
</modules>

<properties>
<addon.exo.ecms.version>6.5.x-SNAPSHOT</addon.exo.ecms.version>
<addon.exo.ecms.version>6.5.x-experience-SNAPSHOT</addon.exo.ecms.version>
<pitest.version>1.4.10</pitest.version>

<sonar.organization>exoplatform</sonar.organization>
Expand Down
2 changes: 1 addition & 1 deletion services/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<parent>
<artifactId>news</artifactId>
<groupId>org.exoplatform.addons.news</groupId>
<version>2.5.x-SNAPSHOT</version>
<version>2.5.x-experience-SNAPSHOT</version>
</parent>
<artifactId>news-services</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion webapp/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<parent>
<artifactId>news</artifactId>
<groupId>org.exoplatform.addons.news</groupId>
<version>2.5.x-SNAPSHOT</version>
<version>2.5.x-experience-SNAPSHOT</version>
</parent>
<artifactId>news-webapp</artifactId>
<packaging>war</packaging>
Expand Down
11 changes: 8 additions & 3 deletions webapp/src/main/webapp/WEB-INF/conf/portal/template/pages/news/page.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,14 @@
template="system:/groovy/portal/webui/container/UIContainer.gtmpl"
cssClass="border-box-sizing">
<access-permissions>Everyone</access-permissions>
<container id="topNewsPage" template="system:/groovy/portal/webui/container/UIContainer.gtmpl">
<access-permissions>*:/platform/users</access-permissions>
</container>
<portlet-application>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should rework the news template layout, to be verified with the PO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the container id="newsPage" is nomore needed, even css classes already added not needed, to be verified with the final look

<portlet>
<application-ref>social-portlet</application-ref>
<portlet-ref>ImagesPortlet</portlet-ref>
</portlet>
<access-permissions>Everyone</access-permissions>
<show-info-bar>false</show-info-bar>
</portlet-application>
<container id="newsBodyPage" template="system:/groovy/portal/webui/container/UIContainer.gtmpl">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<container id="newsBodyPage" template="system:/groovy/portal/webui/container/UIContainer.gtmpl">
<container id="newsBodyPage" template="system:/groovy/portal/webui/container/UIResponsiveColumnGroupContainer.gtmpl.gtmpl">

<access-permissions>Everyone</access-permissions>
<container cssClass="newsBodyPageLeftColumn"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change newsBodyPageRightColumn and newsBodyPageLeftColumn from UIContainer.gtmpl to UISimpleColumnContainer.gtmpl

In that case I think that added css classes are no more needed

Expand Down