feat: Configure Images portlet into news page template - EXO-65514 - Meeds-io/MIPs#68 #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azayati
force-pushed
the
feature/experience
branch
from
c90a091
to
9d15422
Compare
azayati
changed the title
azayati
changed the title
IlhemEssaadi
force-pushed
the
task/65514
branch
2 times, most recently
from
c6fce7c
to
ec14378
Compare
IlhemEssaadi
changed the title
azayati
force-pushed
the
feature/experience
branch
from
9d15422
to
efdf55e
Compare
azayati
requested changes
Aug 17, 2023
| <container id="topNewsPage" template="system:/groovy/portal/webui/container/UIContainer.gtmpl"> | ||
| <access-permissions>*:/platform/users</access-permissions> | ||
| </container> | ||
| <portlet-application> |
There was a problem hiding this comment.
I think that we should rework the news template layout, to be verified with the PO
There was a problem hiding this comment.
I think that the container id="newsPage" is nomore needed, even css classes already added not needed, to be verified with the final look
azayati
requested changes
Aug 18, 2023
| </portlet> | ||
| <access-permissions>Everyone</access-permissions> | ||
| <show-info-bar>false</show-info-bar> | ||
| </portlet-application> | ||
| <container id="newsBodyPage" template="system:/groovy/portal/webui/container/UIContainer.gtmpl"> |
There was a problem hiding this comment.
Suggested change
| <container id="newsBodyPage" template="system:/groovy/portal/webui/container/UIContainer.gtmpl"> | |
| <container id="newsBodyPage" template="system:/groovy/portal/webui/container/UIResponsiveColumnGroupContainer.gtmpl.gtmpl"> |
| </portlet> | ||
| <access-permissions>Everyone</access-permissions> | ||
| <show-info-bar>false</show-info-bar> | ||
| </portlet-application> | ||
| <container id="newsBodyPage" template="system:/groovy/portal/webui/container/UIContainer.gtmpl"> | ||
| <access-permissions>Everyone</access-permissions> | ||
| <container cssClass="newsBodyPageLeftColumn" |
There was a problem hiding this comment.
Change newsBodyPageRightColumn and newsBodyPageLeftColumn from UIContainer.gtmpl to UISimpleColumnContainer.gtmpl
In that case I think that added css classes are no more needed
azayati
requested changes
Aug 21, 2023
| <container id="topNewsPage" template="system:/groovy/portal/webui/container/UIContainer.gtmpl"> | ||
| <access-permissions>*:/platform/users</access-permissions> | ||
| </container> | ||
| <portlet-application> |
There was a problem hiding this comment.
I think that the container id="newsPage" is nomore needed, even css classes already added not needed, to be verified with the final look
IlhemEssaadi
force-pushed
the
task/65514
branch
from
86b3609
to
bddce94
Compare
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
IlhemEssaadi
force-pushed
the
task/65514
branch
3 times, most recently
from
53fc4bd
to
f3bc411
Compare
IlhemEssaadi
force-pushed
the
task/65514
branch
from
f3bc411
to
c298c24
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
exo-swf
force-pushed
the
feature/experience
branch
from
efdf55e
to
096f107
Compare
azayati
changed the title
azayati
pushed a commit
that referenced
this pull request
Aug 23, 2023
exo-swf
pushed a commit
that referenced
this pull request
Aug 25, 2023
IlhemEssaadi
added a commit
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.