Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scaled answers #715

Closed
wants to merge 50 commits into from
Closed

Support scaled answers #715

wants to merge 50 commits into from

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    039161c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b6deb9 View commit details
    Browse the repository at this point in the history
  3. Use repeat/answer/number as input value.

    So 1, 2, 3, etc.
    mauritsvanrees committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    e0e1dfa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d562439 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6d1b8e3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c7aeb77 View commit details
    Browse the repository at this point in the history
  7. Multiple answers: treat 1 and 2 as presenting a risk.

    I had 4 and 5 first.
    mauritsvanrees committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    43d5874 View commit details
    Browse the repository at this point in the history
  8. Fix the risk navigation for multiple answers.

    They were marked as unvisited until now.
    mauritsvanrees committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    1dff68c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    93132b7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    84780d6 View commit details
    Browse the repository at this point in the history
  11. Support specifying the value of multiple_answers.

    By default the first answer gets a value of 1, but if you want to have the "best" answer at the top, you can encode it like this: `very safe|5`.
    mauritsvanrees committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ac5e026 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1e2cf9c View commit details
    Browse the repository at this point in the history
  13. Renamed multiple_answers to scaled_answers.

    In the risk content, use scaled_answers plural to store the possible answers.
    In the risk client (sql), use scaled_answer plural to store the chosen answer.
    mauritsvanrees committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    a42a9ea View commit details
    Browse the repository at this point in the history
  14. RegistryValueVocabulary: filter out empty values.

    There can easily be an empty row at the end.
    mauritsvanrees committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    db3236a View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Configuration menu
    Copy the full SHA
    ab521f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea743f7 View commit details
    Browse the repository at this point in the history
  3. Bump the package version

    ale-rt committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    63c4565 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b43b4e4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    228a348 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    94ad82f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    44f3bcf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    11b9e92 View commit details
    Browse the repository at this point in the history
  9. Fix problem with the identification report not being generated for ce…

    …rtain survey sessions.
    
    Ref: scrum-1846
    Fixes: #688
    thet authored and ale-rt committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    52cc40c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    1b73ed8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    09b868a View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    63a3784 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Configuration menu
    Copy the full SHA
    422e6d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. client navigation: add scaled answer in the risk info.

    The scaled answer itself is not enough to know if the risk is present or not.
    This should be determined based on the module, and this is better done by overriding this method.
    mauritsvanrees committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    130fdf7 View commit details
    Browse the repository at this point in the history
  2. client navigation: refactor getTreeData function to call a browser vi…

    …ew 'oira_navigation_tree'.
    
    Then we can subclass this browser view elsewhere to change the tree in one spot, instead of needing to override the tree in multiple views.
    mauritsvanrees committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b1d7fcb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6923f8a View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    1f9f880 View commit details
    Browse the repository at this point in the history
  2. Fix navigation tests.

    The new oira_navigation_tree cannot be found in the tests.
    This was already true for the webhelpers view in this same file.
    
    So if the view lookup fails, we call the class of the browser view directly.
    mauritsvanrees committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    190ea77 View commit details
    Browse the repository at this point in the history
  3. black.

    I did not have pre-commit activated yet in this repo.
    mauritsvanrees committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6ba279f View commit details
    Browse the repository at this point in the history
  4. Merge pull request #706 from euphorie/multiple-answers-oira-navigatio…

    …n-tree
    
    Refactor getTreeData to use browser view
    mauritsvanrees authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d88c0c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. When getting a scaled answer, set the identification as well.

    Get the idenfication value by calling new method get_identification_from_scaled_answer.
    By default this return None, and with that we set the identification column to NULL, as we did until now.
    In projects that actually use scaled answers, you should override this method.
    mauritsvanrees committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    94d4192 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge pull request #708 from euphorie/multiple-answers-set-identifica…

    …tion
    
    When getting a scaled answer, set the identification as well.
    ale-rt authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    296274a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    2a77c2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b59434a View commit details
    Browse the repository at this point in the history
  3. webhelpers: add use_action_plan_phase.

    This makes it easier to override so we can skip the actionplan phase.
    Check this in the identification view so we know if we need to go to actionplan or consultancy or report.
    mauritsvanrees committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    03b745b View commit details
    Browse the repository at this point in the history
  4. Merge pull request #713 from euphorie/multiple-answers-feedback-issue…

    …-2036
    
    webhelpers: add navigation_tree_legend and use_action_plan_phase methods
    mauritsvanrees authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    24662ee View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    bdc1f8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    454f3db View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Simplify parse_scaled_answers by using rpartition.

    Same number of lines, but easier to understand.
    mauritsvanrees committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c284f90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    26f10c6 View commit details
    Browse the repository at this point in the history
  3. Move property to attribute

    ale-rt committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    95eb61d View commit details
    Browse the repository at this point in the history
  4. Merge pull request #716 from euphorie/multiple-answers-attribute

    Move property to attribute
    mauritsvanrees authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    fca084a View commit details
    Browse the repository at this point in the history
  5. Simplify

    ale-rt committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    8965270 View commit details
    Browse the repository at this point in the history
  6. Update src/euphorie/content/tests/test_utils.py

    Co-authored-by: Maurits van Rees <[email protected]>
    ale-rt and mauritsvanrees authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    ad7b72d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    011103c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    5ce8582 View commit details
    Browse the repository at this point in the history