-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scaled answers #715
Conversation
So 1, 2, 3, etc.
I had 4 and 5 first.
They were marked as unvisited until now.
By default the first answer gets a value of 1, but if you want to have the "best" answer at the top, you can encode it like this: `very safe|5`.
In the risk content, use scaled_answers plural to store the possible answers. In the risk client (sql), use scaled_answer plural to store the chosen answer.
There can easily be an empty row at the end.
…rtain survey sessions. Ref: scrum-1846 Fixes: #688
The scaled answer itself is not enough to know if the risk is present or not. This should be determined based on the module, and this is better done by overriding this method.
…ew 'oira_navigation_tree'. Then we can subclass this browser view elsewhere to change the tree in one spot, instead of needing to override the tree in multiple views.
Same number of lines, but easier to understand.
@ale-rt I made |
Move property to attribute
Ah, sorry, now I get it. Makes sense. I have merged your PR. |
Cherry picked from @mauritsvanrees PR #715
Cherry picked from @mauritsvanrees PR #715
Cherry picked from @mauritsvanrees PR #715
Cherry picked from @mauritsvanrees PR #715
…ew 'oira_navigation_tree'. Then we can subclass this browser view elsewhere to change the tree in one spot, instead of needing to override the tree in multiple views. Taken from #715
These are answers on a scale from usually 1-5, instead of only yes/no. This is the main part from #715. We are pulling that apart into some more digestible chunks, instead of 50 commits, including merges of main.
@ale-rt and me are splitting this up into multiple PRs so it is more understandable. |
The alternative PRs have been merged. We are done here. |
Almost, I merged main in the multiple answer branch and now I have only this thing left:
|
^ This was removed on purpose :) |
Add support for scaled answers. Usually: answers on a scale of 1-5.
This includes improvements in the navigation, mostly creating more possibilities for overriding code.
This seems safe enough to be merged and used, also when the specific project does not use the new scaled answer possibilities.
We could also split this up into multiple PRs, and do git rebases, to make this easier to digest.