-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdctl: remaining errors.Is conversions #18615
etcdctl: remaining errors.Is conversions #18615
Conversation
Signed-off-by: redwrasse <[email protected]>
…ality checks Signed-off-by: redwrasse <[email protected]>
Hi @redwrasse. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 29 files with indirect coverage changes @@ Coverage Diff @@
## main #18615 +/- ##
==========================================
- Coverage 68.78% 68.75% -0.03%
==========================================
Files 420 420
Lines 35519 35519
==========================================
- Hits 24431 24422 -9
- Misses 9662 9669 +7
- Partials 1426 1428 +2 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
LGTM on green, thanks @redwrasse
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, redwrasse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @redwrasse, Thanks for the pull request. I see this has already been merged. I couldn't review it before, but did we miss etcd/etcdctl/ctlv3/command/ep_command.go Line 140 in 0a355d3
|
Yes looks like we did, my fault. Should we open a PR for this, or wait to see if there's a few more stragglers? |
Please raise a separate PR, thanks |
Opened a PR #18625 |
Remaining errors.Is conversions for the etcdctl module, as part of #18576.