-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command: Use errors.Is for error equality check in ep_command.go #18625
Conversation
Signed-off-by: redwrasse <[email protected]>
Hi @redwrasse. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 17 files with indirect coverage changes @@ Coverage Diff @@
## main #18625 +/- ##
==========================================
+ Coverage 68.75% 68.78% +0.03%
==========================================
Files 420 420
Lines 35522 35522
==========================================
+ Hits 24423 24434 +11
+ Misses 9677 9661 -16
- Partials 1422 1427 +5 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @redwrasse.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, redwrasse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow up on #18615 (comment) for using errors.Is in
etcdctl
module, as part of #18576.Use errors.Is for error equality check in
ep_command.go
.