Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: Use errors.Is for error equality check in ep_command.go #18625

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

redwrasse
Copy link
Contributor

Follow up on #18615 (comment) for using errors.Is in etcdctl module, as part of #18576.

Use errors.Is for error equality check in ep_command.go.

@k8s-ci-robot
Copy link

Hi @redwrasse. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.78%. Comparing base (bd93a00) to head (d34e23a).

Current head d34e23a differs from pull request most recent head 6767e1f

Please upload reports for the commit 6767e1f to get more accurate results.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/ep_command.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
etcdctl/ctlv3/command/ep_command.go 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18625      +/-   ##
==========================================
+ Coverage   68.75%   68.78%   +0.03%     
==========================================
  Files         420      420              
  Lines       35522    35522              
==========================================
+ Hits        24423    24434      +11     
+ Misses       9677     9661      -16     
- Partials     1422     1427       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd93a00...6767e1f. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Sep 23, 2024

/ok-to-test

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @redwrasse.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, redwrasse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit c79c7d5 into etcd-io:main Sep 24, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants