Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ampq 3.0 and amqp_client 3.9.x #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leductam
Copy link

@leductam leductam commented Sep 6, 2021

Starting from amqp-3.0, :lager will no longer be required then removes :lager configuration.
If still use amqp 1.x/2.x already had :lager in them applications configs then it's fine to remove :lager from extra_applications: of ex_rabbit_pool mix.exs.

This also removes Lager configuration
@Efesto
Copy link

Efesto commented Sep 28, 2021

credentials_obfuscation, introduced in this PR, is not supported on OTP 21 anymore

@leductam
Copy link
Author

credentials_obfuscation, introduced in this PR, is not supported on OTP 21 anymore

In case you have to use OTP 21 then should be use the appropriate amqp version. My PR just for the next releases of amqp/amqp_client and of course that it just an option.

@Efesto
Copy link

Efesto commented Sep 30, 2021

In case you have to use OTP 21 then should be use the appropriate amqp version. My PR just for the next releases of amqp/amqp_client and of course that it just an option.

Yop, I wanted to point out that the integration pipeline is red for that reason but I'm not sure what would be the best way to proceed, probably by updating mix.lock by locking the library versions for amqp 1.2 as it is on master branch

@Efesto
Copy link

Efesto commented Jan 30, 2023

Any chance for this to get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants