-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipeline component examples catalogs for KFP and AA and MLX connector #79
Add pipeline component examples catalogs for KFP and AA and MLX connector #79
Conversation
component-catalog-connectors/example-components-connector/README.md
Outdated
Show resolved
Hide resolved
...talog-connectors/example-components-connector/elyra_examples_connector/examples_connector.py
Outdated
Show resolved
Hide resolved
Please make sure to update LICENSE files accordingly to mention new files as in PR 2272 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great! I installed from source for my tests
component-catalog-connectors/example-components-connector/README.md
Outdated
Show resolved
Hide resolved
...talog-connectors/example-components-connector/elyra_examples_connector/examples_connector.py
Outdated
Show resolved
Hide resolved
The updates sound great. I still think it would be good to expose a filter/regex schema property that can be applied so users can build connector instances that are subsets of the complete set. |
Thank you, I have totally missed that. I added a license file to the Kubeflow Pipelines connector's |
Sorry - I just noticed my comments were applied to a specific commit, which requires you to have to open the commit link to get their context. What a hassle - I apologize. |
component-catalog-connectors/airflow-example-components-connector/README.md
Show resolved
Hide resolved
component-catalog-connectors/airflow-example-components-connector/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the circular ref comment below, the connector schemas should include the following updates (can't apply in-line commenting so adding here):
- The
$id
values still reflect the combined form of the repo - The
display_name
property should be removed as it's redundant withtitle
. (This comment is NOT apply to thedisplay_name
property definition down in theproperties
stanza - which applies to instances.) All schemas are being updated in this manner in Remove references to schema display_name property elyra#2267 - The
schemaspace
andschemaspace_id
values should be updated tocomponent-catalogs
and8dc89ca3-4b90-41fd-adb9-9510ad346620
, respectively once Component catalogs schemaspace elyra#2282 is merged.
component-catalog-connectors/airflow-example-components-connector/setup.py
Outdated
Show resolved
Hide resolved
Fixed in both schemas!
Removed the top level
Adding this to the TODO list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I incorporated the changes that this PR is dependent on and tested all three catalog types -- all are working great
Done! |
@akchinSTC @lresende @kevin-bates @kiersten-stokes you should have received pending collaborator invitations for three packages from PyPI |
For test purposes version 0.0.1 of each package was published to unblock elyra-ai/elyra#2286. Once development has completed and no issues were found version 0.0.1 will be replaced by 0.1.0. |
This PR
requires Add support Runtime types elyra#2263RESOLVEDrequires Remove references to schema display_name property elyra#2267 (RESOLVED+
>New undefined
shown until merged)requires Component catalogs schemaspace elyra#2282RESOLVEDAdd examples catalog user experience (Airflow shown):
Open "Manage Components"
Add catalog (
+
)New Apache Airflow example components catalog
Enter a catalog name (any string) - all other inputs are pre-populated.
Note that the Learn more... link opens the connector's GitHub repository README, which contains information about the connector. (For built-in catalog types the link opens the pipeline components topic in the user guide, which introduces catalogs.)
Expand palette in VPE
Note that the following information is persisted for each node in the
.pipeline
file (irrelevant information was removed from the KFP snippet below):Airflow:
Developer's Certificate of Origin 1.1