-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle pipeline migration concerns for BYO catalog type changes #2262
Comments
#2272 will affect migration for the ops/ids and the |
The Runtime Types PR (#2263) essentially takes the old format of the pipeline file's "app_data": {
"ui_data": {
"comments": []
},
"version": 5,
"runtime": "kfp",
"properties": {
"name": "kfp_custom",
"runtime": "kfp",
"description": "3-node custom component pipeline"
}
}, and converts to this format: "app_data": {
"ui_data": {
"comments": []
},
"version": 6,
"runtime": "kfp",
"runtime_type": "KUBEFLOW_PIPELINES",
"properties": {
"name": "kfp_custom",
"description": "3-node custom component pipeline"
}
}, To summarize:
(*): a non-existent or empty Test assets (pipeline files) have been updated for the integration tests (but left at version 5). Server test resources (pipeline files) have only been updated as needed (and also left at version 5). |
Here's a table summarizing the before/after. The This table is up to date with the latest from examples PR #79 and #2286 as of 11.10
|
@ajbozarth - please see my update to the table in #2262 (comment). With the changes in #2287, it's important that "generic" not appear as a |
Addresses elyra-ai/elyra#2262 Increments pipeline version to 6 and add migration code Tests to be added in followup PR
Fixes #2262 Sister PR to elyra-ai/pipeline-editor#172 Update the pipeline version and migration code to handle the changes in Elyra 3.3 Pin package versions to prevent future backwards compatibility errors Co-authored-by: Alan Chin <[email protected]>
Is your feature request related to a problem? Please describe.
We will have another 1:1 node
op
change for our preloaded components that will require some frontend pipeline migration and migration of our pytest resources.Describe the solution you'd like
The following 1:1 mapping should work for the built-in catalog components:
We should also have the following mapping for the
component_source
property for the properties below (old -> new
):"component_Calculatedatahash/"url-catalog:4fc759382b1b"
:"component_Downloaddata"/"url-catalog:c6c0588048ae"
"bash_operator_BashOperator"/"url-catalog:49f8e61b78c3"
:"email_operator_EmailOperator"/"url-catalog:8bef428ea3cd"
:"http_operator_SimpleHttpOperator"/"url-catalog:e97030fb448a"
:"spark_sql_operator_SparkSqlOperator"/"url-catalog:ff0d51b70719"
:"spark_submit_operator_SparkSubmitOperator"/"url-catalog:2756314f3ff5"
:The remaining 3 components are a bit stickier in that the old and new values include absolute locations on a user's machine. The general format for these components will be as follows:
"run_notebook_using_papermill_Runnotebookusingpapermill"/"local-directory-catalog:61e6f4141f65"
:"filter_text_using_shell_and_grep_Filtertext"/"local-directory-catalog:737915b826e9"
:"slack_operator_SlackAPIPostOperator"/"local-file-catalog:81b4f925702e"
:Additional context
Since this is a relatively easy change, I would probably hold off on implementing it until we're sure that we've finalized these
op
s.The text was updated successfully, but these errors were encountered: