Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowClone: Layout in allocate virtual #2082

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Oct 10, 2024

Currently we are doing most of the layout management by hardcoding x, y, width and height of our child actors. However we can make the whole thing simpler and more robust by doing the layout management in the allocate virtual method as recommended by clutter docs.

Since the root cause for the following issues was that we didn't allocate some children on rare occasions which was fixed in this PR this
fixes #2053 and
fixes #1898 and therefore
closes #2072

There are still some issues when windows spawn while multitasking view is open (like for example they reserve space but don't show) that I would like to tackle in follow up PRs but at least it doesn't completely break anymore as on current main :)

fixes #2088

@leolost2605 leolost2605 requested a review from a team October 10, 2024 12:18
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the linked issues, but it looks like the textures (window clones, close buttons, app icons) are all rendered half a pixel offset so they're blurry (this is on LoDPI and Wayland)

@danirabbit
Copy link
Member

Tooltips also appear to be cut off and text looks pretty gnarly. Although when I went back to get a screenshot the other textures all look aligned correctly here 🤔

This branch:
Screenshot from 2024-10-11 10 47 41

main:
Screenshot from 2024-10-11 10 48 45

@leolost2605
Copy link
Member Author

@danirabbit the allocations are clamped to pixels now could you try again with that? I'm not so good at noticing those differences 😅
(and the tooltip thing I don't seem to be able to reproduce, probably requires a very specific window size and name 🤷)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants