Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending images from the keyboard #2131

Merged
merged 2 commits into from
Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1977.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add support for sending images from the keyboard
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package io.element.android.features.messages.impl.messagecomposer

import android.net.Uri
import androidx.compose.runtime.Immutable
import io.element.android.features.messages.impl.mentions.MentionSuggestion
import io.element.android.libraries.textcomposer.model.Message
Expand All @@ -26,6 +27,7 @@
sealed interface MessageComposerEvents {
data object ToggleFullScreenState : MessageComposerEvents
data class SendMessage(val message: Message) : MessageComposerEvents
data class SendUri(val uri: Uri) : MessageComposerEvents

Check warning on line 30 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerEvents.kt

View check run for this annotation

Codecov / codecov/patch

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerEvents.kt#L30

Added line #L30 was not covered by tests
data object CloseSpecialMode : MessageComposerEvents
data class SetMode(val composerMode: MessageComposerMode) : MessageComposerEvents
data object AddAttachment : MessageComposerEvents
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,18 @@
updateComposerMode = { messageComposerContext.composerMode = it },
richTextEditorState = richTextEditorState,
)
is MessageComposerEvents.SendUri -> appCoroutineScope.sendAttachment(
attachment = Attachment.Media(
localMedia = localMediaFactory.createFromUri(
uri = event.uri,
mimeType = null,
name = null,
formattedFileSize = null

Check warning on line 234 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerPresenter.kt

View check run for this annotation

Codecov / codecov/patch

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerPresenter.kt#L229-L234

Added lines #L229 - L234 were not covered by tests
),
compressIfPossible = true

Check warning on line 236 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerPresenter.kt

View check run for this annotation

Codecov / codecov/patch

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerPresenter.kt#L236

Added line #L236 was not covered by tests
),
attachmentState = attachmentsState,

Check warning on line 238 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerPresenter.kt

View check run for this annotation

Codecov / codecov/patch

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerPresenter.kt#L238

Added line #L238 was not covered by tests
)
is MessageComposerEvents.SetMode -> {
messageComposerContext.composerMode = event.composerMode
when (event.composerMode) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package io.element.android.features.messages.impl.messagecomposer

import android.net.Uri
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.IntrinsicSize
import androidx.compose.foundation.layout.height
Expand Down Expand Up @@ -52,6 +53,10 @@
state.eventSink(MessageComposerEvents.SendMessage(message))
}

fun sendUri(uri: Uri) {
state.eventSink(MessageComposerEvents.SendUri(uri))

Check warning on line 57 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerView.kt

View check run for this annotation

Codecov / codecov/patch

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerView.kt#L57

Added line #L57 was not covered by tests
}

fun onAddAttachment() {
state.eventSink(MessageComposerEvents.AddAttachment)
}
Expand Down Expand Up @@ -117,6 +122,7 @@
onSuggestionReceived = ::onSuggestionReceived,
onError = ::onError,
currentUserId = state.currentUserId,
onRichContentSelected = ::sendUri,
)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package io.element.android.libraries.textcomposer

import android.net.Uri
import androidx.compose.foundation.background
import androidx.compose.foundation.border
import androidx.compose.foundation.clickable
Expand Down Expand Up @@ -111,6 +112,7 @@ fun TextComposer(
onDeleteVoiceMessage: () -> Unit,
onError: (Throwable) -> Unit,
onSuggestionReceived: (Suggestion?) -> Unit,
onRichContentSelected: ((Uri) -> Unit)?,
modifier: Modifier = Modifier,
showTextFormatting: Boolean = false,
subcomposing: Boolean = false,
Expand Down Expand Up @@ -162,6 +164,7 @@ fun TextComposer(
resolveMentionDisplay = { text, url -> TextDisplay.Custom(mentionSpanProvider.getMentionSpanFor(text, url)) },
resolveRoomMentionDisplay = { TextDisplay.Custom(mentionSpanProvider.getMentionSpanFor("@room", "#")) },
onError = onError,
onRichContentSelected = onRichContentSelected,
)
}
}
Expand Down Expand Up @@ -397,6 +400,7 @@ private fun TextInput(
resolveMentionDisplay: (text: String, url: String) -> TextDisplay,
modifier: Modifier = Modifier,
onError: (Throwable) -> Unit = {},
onRichContentSelected: ((Uri) -> Unit)? = null,
) {
val bgColor = ElementTheme.colors.bgSubtleSecondary
val borderColor = ElementTheme.colors.borderDisabled
Expand Down Expand Up @@ -443,7 +447,8 @@ private fun TextInput(
style = ElementRichTextEditorStyle.composerStyle(hasFocus = state.hasFocus),
resolveMentionDisplay = resolveMentionDisplay,
resolveRoomMentionDisplay = resolveRoomMentionDisplay,
onError = onError
onError = onError,
onRichContentSelected = onRichContentSelected,
)
}
}
Expand Down Expand Up @@ -902,5 +907,6 @@ private fun ATextComposer(
onDeleteVoiceMessage = {},
onError = {},
onSuggestionReceived = {},
onRichContentSelected = null,
)
}
Loading