Add support for sending images from the keyboard

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Add ability to send media from the keyboard

Need matrix-org/matrix-rich-text-editor#915

Motivation and context

Better integration with the major Android keyboards, and parity with EA.
Closes #1977

Screenshots / GIFs

Tests

• Open a room with permission to send message
• From the keyboard, select an image
• observe that the image is sent to the room

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[jmartinesp]

I tested this on several devices and it worked just fine on all but one, but I've also seen other weird issues in it, so it might be an OS issue.

Worst case scenario: we'll need to re-visit this feature in the feature to find what's wrong with that specific device.

[jmartinesp]

Btw, I tested this again with another device and it also worked as expected, so I have no idea what's the problem with the one I used for testing before. I guess we can merge this if the CI passes?

[bmarty]

Using the device with the issue @jmartinesp does it work correctly with EA (with RTE disabled), or with other messaging apps or anything else supporting sending image from KB?

[jmartinesp]

Using the device with the issue @jmartinesp does it work correctly with EA (with RTE disabled), or with other messaging apps or anything else supporting sending image from KB?

In EA it works with the RTE disabled, it also works in Telegram or the SMS app 😞 .

I have some logs:

E CommitContentHelper: CommitContentHelper.share():53 No shareable uris mime-types [image/png] match editor mime-types []

[jmartinesp]

I actually got it working! We need to override commitContent to return true in the InterceptInputConnection class in the RTE editor (I guess depending on the API version it returns true or false by default), and possibly add some extra config in onCreateInputConnection. I'll check the details tomorrow.

[jmartinesp]

I actually got it working! We need to override commitContent to return true in the InterceptInputConnection class in the RTE editor (I guess depending on the API version it returns true or false by default), and possibly add some extra config in onCreateInputConnection. I'll check the details tomorrow.

Added a fix here: matrix-org/matrix-rich-text-editor#919

[bmarty]

(Updated the branch to get the latest version of the RTE lib)

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Nd3GRn

[codecov]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ad9a174) 67.00% compared to head (b6f88f9) 66.98%.
Report is 2 commits behind head on develop.

Files	Patch %	Lines
...s/impl/messagecomposer/MessageComposerPresenter.kt	0.00%	8 Missing and 1 partial ⚠️
...ages/impl/messagecomposer/MessageComposerEvents.kt	0.00%	1 Missing ⚠️
...ssages/impl/messagecomposer/MessageComposerView.kt	50.00%	1 Missing ⚠️
...ent/android/libraries/textcomposer/TextComposer.kt	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2131      +/-   ##
===========================================
- Coverage    67.00%   66.98%   -0.03%     
===========================================
  Files         1376     1376              
  Lines        34243    34259      +16     
  Branches      7456     7459       +3     
===========================================
+ Hits         22945    22948       +3     
- Misses        7675     7686      +11     
- Partials      3623     3625       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.