Add maximum length to configuration put step definition
#3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coduz
requested changes
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## develop #3812 +/- ##
==========================================
Coverage 22.22% 22.22%
Complexity 6 6
==========================================
Files 1876 1876
Lines 35439 35448 +9
Branches 2783 2785 +2
==========================================
+ Hits 7876 7879 +3
- Misses 27251 27257 +6
Partials 312 312
|
MDeLuise
force-pushed
the
fix/large-configuration-put
branch
from
02b9cac
to
5ef0d25
Compare
A configuration cannot have more than 65535 characters, due to the database column `TEXT` definition. Adding the validation in the frontend permits to fail fast illegal requests without sending them to the backend. Also add check on backend.
MDeLuise
force-pushed
the
fix/large-configuration-put
branch
from
5ef0d25
to
33b290a
Compare
Coduz
approved these changes
Jul 13, 2023
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR
Due to the fact that the database column
property_valueis of typeTEXT, a configuration cannot have more than 65535 characters.This because the column type
TEXTcan hold data up to about 64 Kilobytes size.This PR adds a validation in the frontend that permits to illegal requests to fail fast without even sending them to the backend.
Related Issue
This PR relates to #3469.
Description of the solution adopted
A proper maximum length is forced to the textarea.