Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(job): Increased length of JobStepProperty.propertyValue field to allow up to 4GB #3828

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jul 24, 2023

This PR increase the maximum length for JobStepProperty.propertyValue field, from 65k to 4GB softlimited ad 100MB

Related Issue
This PR relates to changes made in #3812 and solves #3469

Description of the solution adopted
Column for the field has been changed from TEXT to LONGTEXT, which in Maria DB increased the maximum allowed value from 65KB to 4GB.

A configurable soft limit has been set at 100MB.

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #3828 (adf431b) into develop (f1e7bfc) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

❗ Current head adf431b differs from pull request most recent head 4523a52. Consider uploading reports for the commit 4523a52 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3828      +/-   ##
=============================================
- Coverage      20.57%   20.56%   -0.01%     
  Complexity         6        6              
=============================================
  Files           1894     1896       +2     
  Lines          40475    40494      +19     
  Branches        3874     3877       +3     
=============================================
  Hits            8326     8326              
- Misses         31737    31756      +19     
  Partials         412      412              
Files Changed Coverage Δ
...e/job/internal/settings/JobServiceSettingKeys.java 0.00% <0.00%> (ø)
...vice/job/internal/settings/JobServiceSettings.java 0.00% <0.00%> (ø)
.../service/job/step/internal/JobStepServiceImpl.java 0.00% <0.00%> (ø)

@Coduz Coduz force-pushed the feat-longerJobStepPropertyValue branch from e374492 to 73f5512 Compare July 26, 2023 09:24
@Coduz Coduz changed the title feat(job) Increased length of JobStepProperty.propertyValue field to allow up to 4GB feat(job): Increased length of JobStepProperty.propertyValue field to allow up to 4GB Jul 26, 2023
…xt (65KB) to longtext (4GB)

Signed-off-by: Alberto Codutti <[email protected]>
…x' as soft limit for JobStepProperty.propertyValue

Signed-off-by: Alberto Codutti <[email protected]>
@Coduz Coduz force-pushed the feat-longerJobStepPropertyValue branch from 73f5512 to 4523a52 Compare July 26, 2023 16:21
@Coduz Coduz merged commit a5a199b into eclipse:develop Jul 27, 2023
29 of 30 checks passed
@Coduz Coduz deleted the feat-longerJobStepPropertyValue branch July 27, 2023 07:33
Coduz added a commit to Coduz/kapua that referenced this pull request Aug 23, 2023
Coduz added a commit to Coduz/kapua that referenced this pull request Aug 24, 2023
Coduz added a commit to Coduz/kapua that referenced this pull request Aug 24, 2023
Coduz added a commit that referenced this pull request Aug 25, 2023
Coduz added a commit to Coduz/kapua that referenced this pull request Aug 28, 2023
Coduz added a commit to Coduz/kapua that referenced this pull request Aug 28, 2023
Coduz added a commit to Coduz/kapua that referenced this pull request Aug 30, 2023
Coduz added a commit to Coduz/kapua that referenced this pull request Aug 31, 2023
Coduz added a commit that referenced this pull request Aug 31, 2023
Coduz added a commit that referenced this pull request Sep 1, 2023
…bEngine

fix(jobEngine): Changed 'jbtc_job_status.obj' type to longblob to support changes made in #3828
Coduz added a commit that referenced this pull request Sep 1, 2023
Coduz added a commit that referenced this pull request Sep 1, 2023
Coduz added a commit that referenced this pull request Sep 1, 2023
Coduz added a commit to Coduz/kapua that referenced this pull request Sep 6, 2023
… 10MB that wasa introduced in eclipse#3828

Signed-off-by: Alberto Codutti <[email protected]>
Coduz added a commit that referenced this pull request Sep 11, 2023
… 10MB that wasa introduced in #3828

Signed-off-by: Alberto Codutti <[email protected]>
Coduz added a commit that referenced this pull request Sep 11, 2023
… 10MB that wasa introduced in #3828

Signed-off-by: Alberto Codutti <[email protected]>
Coduz added a commit that referenced this pull request Sep 11, 2023
… 10MB that wasa introduced in #3828

Signed-off-by: Alberto Codutti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
Development

Successfully merging this pull request may close these issues.

1 participant