Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Industry Core KIT] BugFix: remove faulty JSON-examples for aspect models #1056

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+29 −39
Open

[Industry Core KIT] BugFix: remove faulty JSON-examples for aspect models #1056

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
17dbf1a
Update page_aspect-models.mdx
johannsvarela Oct 15, 2024
88ac5c6
Update page_changelog.mdx
johannsvarela Oct 16, 2024
e9b1ed7
Update page_changelog.mdx
johannsvarela Oct 16, 2024
64fdc0c
Update page_changelog.mdx
johannsvarela Oct 22, 2024
75b0a66
Merge branch 'main' into bugfix/industry-core-1.1.1
johannsvarela Oct 22, 2024
c28f565
Update page_aspect-models.mdx
johannsvarela Oct 23, 2024
d9d4d68
Update page_changelog.mdx
johannsvarela Oct 23, 2024
ab9342f
Update page_aspect-models.mdx
johannsvarela Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions docs-kits/kits/Industry Core Kit/Software Development View/page_aspect-models.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,6 @@ Aspect model in GitHub:
"key": "manufacturerId",
"value": "BPNL7588787849VQ"
},
{
"key": "manufacturerPartId",
"value": "95657362-83"
},
{
"key": "partInstanceId",
"value": "OEM-A-F8LM95T92WJ9KNDD3HA5P"
Expand Down Expand Up @@ -231,10 +227,6 @@ Aspect model in GitHub:
"key": "manufacturerId",
"value": "BPNL7588787849VQ"
},
{
"key": "manufacturerPartId",
"value": "95657362-83"
},
{
"key": "partInstanceId",
"value": "NO-574868639429552535768526"
Expand Down Expand Up @@ -293,13 +285,13 @@ Aspect model in GitHub:
"key": "batchId"
},
{
"value": "123-0.740-3434-A",
"key": "manufacturerPartId"
"key": "manufacturerId",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the batch aspect itself, I still see differences between the semantic model example and how we describe it here. What you did is an improvement, for sure: Would you also remove the resulting differences?
I guess this also applies to the other aspect models

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eckardg regarding the "differences", do you mean changing the examples in the Aspect models?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, currently when I compare the examples in the aspect models and the examples in the KIT I see differences. Wouldn'it it be easier to adapt the examples in the KIT?

"value": "BPNL7588787849VQ"
},
],
"manufacturingInformation": {
"date": "2022-02-04T14:48:54",
"country": "HUR",
"country": "DEU",
"sites": [
{
"catenaXsiteId": "BPNS1234567890ZZ",
Expand Down Expand Up @@ -355,14 +347,6 @@ Aspect model in GitHub:
"key": "parentOrderNumber",
"value": "OEM-A-F8LM95T92WJ9KNDD3HA5P"
},
{
"key": "manufacturerPartId",
"value": "84816168424"
},
{
"key": "nameAtManufacturer",
"value": "Black Leather Front Row Seat for Vehicle Model B"
},
{
"key": "jisCallDate",
"value": "2022-01-24T09:13:34"
Expand Down
11 changes: 11 additions & 0 deletions docs-kits/kits/Industry Core Kit/page_changelog.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,17 @@ import Notice from './part_notice.mdx'

All notable changes to this Kit will be documented in this file.

## [1.1.1] - 2024-10-23

Compatible for **release 24.08**.

### Removed

- **Development View:**
- **Aspect Models:**
- Removed the *manufacturerPartId* in the key-value list of the localIdentifiers for the SerialPart, Batch and JustInsequencePart JSON-Example
- Replaced the faulty (production) country abbreviation in the JSON-Example of the Batch aspect model from *HUR* to *DEU*

## [1.1.0] - 2024-07-11

Compatible for **release 24.08**.
Expand Down
Loading