[Industry Core KIT] BugFix: remove faulty JSON-examples for aspect models

[johannsvarela]

Description

This PR fixes bugs in the JSON-Examples for the SerialPart, Batch and JustInSequencePart aspect models of the section Development View / Aspect Models. For more details have a look at the changelog.

The bugfix will affect these KIT versions:

• 24.08 -> docs-kits_versioned_docs/version-24.08/kits/Industry Core Kit/Software Development View/page_aspect-models.mdx
• 24.12 -> docs-kits/kits/Industry Core Kit/Software Development View/page_aspect-models.mdx

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

• DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
• Copyright and license header are present on all affected files

[eckardg]

Looking at the batch aspect itself, I still see differences between the semantic model example and how we describe it here. What you did is an improvement, for sure: Would you also remove the resulting differences?
I guess this also applies to the other aspect models

[johannsvarela]

@eckardg regarding the "differences", do you mean changing the examples in the Aspect models?

[eckardg]

Yes, currently when I compare the examples in the aspect models and the examples in the KIT I see differences. Wouldn'it it be easier to adapt the examples in the KIT?

[eckardg]

It would be great if you could also remove further differences :-)

[arnoweiss]

Can you state the motivation for removing the manufacturerPartId?

[johannsvarela]

Can you state the motivation for removing the manufacturerPartId?

@arnoweiss the manufactuererPartid is not part of the LocalIdentifier, but is described in the partTypeInformation section below. Therefore the existing example is faulty.

[johannsvarela]

It would be great if you could also remove further differences :-)

@eckardg Unfortunately, we cannot use the same examples from the Aspect models for the KITs because the examples from the Aspect models only allow one example per attribute and therefore no list of examples of arrays such as the LocalIdentifiers, sites, or PartClassification can be generated.

If you want, I can harmonize the values from the aspect models with the KIT examples, but the structure in the example in KIT will not be the same as in the apsect models for the reason explained above.

Do you get my point? 😄

[eckardg]

Thanks for your explanation. It is now fine for me, thanks!

[tom-rm-meyer-ISST]

LGTM