Iox #910 quality declaration document

[dkroenke]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

With this quality declaration document are the quality measures are made visible according to ROS REP 2004.
This document focus on the software quality of the iceoryx_hoofs, iceoryx_posh and iceoryx_binding_c packages.

In addition to quality level 2 the document shall also list the diff for reaching quality level 1 in ROS 2.
All Committers and PMC lead are added as reviewers for informational purpose.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Add Quality Declaration Document #910

[mossmaurice]

Great write-up, thanks! The current status-quo looks really good :-)

[codecov]

Codecov Report

Merging #918 (fa41575) into master (72a5cf7) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
+ Coverage   77.51%   77.60%   +0.08%     
==========================================
  Files         335      336       +1     
  Lines       12267    12309      +42     
  Branches     1831     1831              
==========================================
+ Hits         9509     9552      +43     
  Misses       2131     2131              
+ Partials      627      626       -1     

Flag	Coverage Δ
unittests	76.50% <ø> (+0.08%)	⬆️
unittests_timing	30.48% <ø> (+0.26%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
iceoryx_posh/source/roudi/process_manager.cpp	62.01% <0.00%> (-0.30%)	⬇️
iceoryx_binding_c/source/c_config.cpp	100.00% <0.00%> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp	85.29% <0.00%> (+5.88%)	⬆️

[mossmaurice]

LGTM!