Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nullptr callbacks correctly in WaitSet and Listener #932

Closed
3 tasks done
dkroenke opened this issue Sep 30, 2021 · 2 comments · Fixed by #933 or #937
Closed
3 tasks done

Handle nullptr callbacks correctly in WaitSet and Listener #932

dkroenke opened this issue Sep 30, 2021 · 2 comments · Fixed by #933 or #937
Assignees
Labels
refactoring Refactor code without adding features

Comments

@dkroenke
Copy link
Member

dkroenke commented Sep 30, 2021

Brief description

When checking the WaitSet and Listener tests with ASAN on gcc an error is thrown that a nullptr is de-referenced when a nullptr is passed as callback function to functions like iox_ws_attach_subscriber_event or iox_listener_attach_subscriber_event in the C-Binding.

In the WaitSet it should be possible for the users to use nullptr callback arguments if they want to wait in a loop.

Reference Links:
#918 (comment)
#918 (comment)

  • Enable in CI the ASAN check with latest gcc compiler
  • Refactor WaitSet and Listener to accept (or disallow) nullptr arguments
  • Test explicitly against this
@dkroenke dkroenke added the refactoring Refactor code without adding features label Sep 30, 2021
@dkroenke dkroenke self-assigned this Sep 30, 2021
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Sep 30, 2021
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Sep 30, 2021
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Sep 30, 2021
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Oct 1, 2021
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Oct 1, 2021
dkroenke added a commit that referenced this issue Oct 1, 2021
…-in-waitset-and-listener

Iox #932 handle nullptr callbacks in waitset
@dkroenke dkroenke reopened this Oct 1, 2021
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Oct 7, 2021
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Oct 7, 2021
Includes the C-Binding

Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit that referenced this issue Oct 8, 2021
…-in-listener

iox-#932 Handle nullptr callbacks in Listener
@elBoberido
Copy link
Member

@dkroenke I noticed that the tasks are not checked. Are they all done or this this issue need to be reopened?

@dkroenke
Copy link
Member Author

@elBoberido All done

elBoberido added a commit to ApexAI/iceoryx that referenced this issue Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
2 participants