Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Added required 'packages: write' permission to Publish Snapshot workflow #68

Closed
wants to merge 1 commit into from

Conversation

mehmetihsansevinc
Copy link
Contributor

What this PR changes/adds

Gives the "packages: write" permission to trigger_snapshot.yml .

Why it does that

Publish Snapshot Build workflow throws the following "The workflow is not valid. .github/workflows/trigger_snapshot.yml (Line: 11, Col: 3): Error calling workflow 'eclipse-edc/.github/.github/workflows/publish-snapshot.yml@main'. The nested job 'Publish-Snapshot' is requesting 'packages: write', but is only allowed 'packages: read'." message so relevant permission is given in the workflow file..

Linked Issue(s)

Closes # <-- #66

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt
Copy link
Member

ndr-brt commented Sep 20, 2024

thanks for providing the PR, but I think the problem is on an higher level:
https://github.com/eclipse-edc/.eclipsefdn/blob/main/otterdog/eclipse-edc.jsonnet#L364

@ndr-brt
Copy link
Member

ndr-brt commented Sep 20, 2024

it will be fixed by this PR:
eclipse-edc/.eclipsefdn#26

this one can be closed

@ndr-brt
Copy link
Member

ndr-brt commented Sep 23, 2024

this was an issue with the upstream workflow definition, fixed by:
eclipse-edc/.github@f2a3d9d
(because we don't need write permission on packages at all)

this can be closed as the issue is already fixed, as demonstrated by a manually triggered build:
https://github.com/eclipse-edc/Technology-HuaweiCloud/actions/runs/10990277426

@ndr-brt ndr-brt closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants