-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: give HuaweiCloud repo workflow write permissions #26
Conversation
This is your friendly self-service bot. Thank you for raising a pull request to update the configuration of your GitHub organization. The following conditions need to fulfilled for auto-merging to be available:
Otterdog commands and optionsYou can trigger otterdog actions by commenting on this PR:
|
This is your friendly self-service bot. Diff for 7244f9bOrganization technology.edc[id=eclipse-edc]
╷
│ Warning: repository[name="FederatedCatalog"] has 'gh_pages_build_type' with value 'legacy' but no corresponding 'github-pages' environment, please add such an environment.
╵
╷
│ Warning: repository[name="IdentityHub"] has 'gh_pages_build_type' with value 'legacy' but no corresponding 'github-pages' environment, please add such an environment.
╵
there have been 20 validation infos, enable verbose output with '-v' to to display them.
! repo_workflow_settings[repository="Technology-HuaweiCloud"] {
! default_workflow_permissions = "read" -> "write"
! }
Plan: 0 to add, 1 to change, 0 to delete. |
This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀 |
actually the OP of eclipse-edc/Technology-HuaweiCloud#68 is correct. You have to grant the called workflow the required permissions. Your organization grants by default read only permissions to all workflows and I would strongly advise to keep it that way. It usually much less work to add the required permissions on a workflow basis instead of just granting write by default and then fix them all together at a later time when we are asking all our project to use read by default as this is the best practice. As you already use read by now, it does not really make sense to go back to write. |
all the other repos have "write", if that's not a best practice we should change them back to "read", and have to update all of the specific workflow, right? |
yes indeed, in the long term we would like that all projects / repositories use read by default, however I understand that there is effort involved, so we also work on tools to help you doing that. Having said that, whenever there is a chance to already use read, do it as it will save you work in the long run imho. |
Got it, thanks for your explaination |
What this PR changes/adds
give HuaweiCloud repo workflow write permissions
Why it does that
it needs those
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes eclipse-edc/Technology-HuaweiCloud#66
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.