Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1423 zran check fail, because validate_header zran_count > chunk_count #1437

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NehemiahMi
Copy link

Relevant Issue (if applicable)

#1423

Details

  1. targz-ref jump deduplicate chunk, because zran hasn't duplication
  2. targz-ref rebuild filesystem chunk need not map

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@NehemiahMi NehemiahMi requested a review from a team as a code owner October 10, 2023 12:19
@NehemiahMi NehemiahMi requested review from bergwolf, liubin and gaius-qi and removed request for a team October 10, 2023 12:19
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1437 (77f8df7) into master (9ab1ec1) will increase coverage by 16.20%.
Report is 44 commits behind head on master.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1437       +/-   ##
===========================================
+ Coverage   46.29%   62.50%   +16.20%     
===========================================
  Files         123      123               
  Lines       38872    43158     +4286     
  Branches    38872    43158     +4286     
===========================================
+ Hits        17997    26974     +8977     
+ Misses      19906    14874     -5032     
- Partials      969     1310      +341     
Files Coverage Δ
builder/src/core/node.rs 82.49% <100.00%> (+40.95%) ⬆️
rafs/src/metadata/direct_v6.rs 44.67% <100.00%> (+38.18%) ⬆️
rafs/src/metadata/mod.rs 70.99% <ø> (+18.50%) ⬆️
builder/src/core/v6.rs 75.38% <0.00%> (+43.04%) ⬆️
rafs/src/metadata/layout/v6.rs 85.04% <0.00%> (+29.46%) ⬆️

... and 67 files with indirect coverage changes

…count > chunk_count

1. targz-ref jump deduplicate chunk, because zran hasn't duplication
2. targz-ref rebuild filesystem chunk need not map

Signed-off-by: 伏鸾 <[email protected]>
@imeoer
Copy link
Collaborator

imeoer commented Nov 1, 2023

@@ -1349,7 +1349,7 @@ impl RafsInodeExt for OndiskInodeWrapper {
blob_index, chunk_index
))
})
} else if state.is_tarfs() {
} else if state.is_tarfs() || state.meta.has_inlined_chunk_digest() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help to give more information about the context to trigger this issue?

@imeoer
Copy link
Collaborator

imeoer commented Dec 5, 2023

What's the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants