Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert & Check Images work error #1423

Open
Desiki-high opened this issue Sep 13, 2023 · 4 comments
Open

Convert & Check Images work error #1423

Desiki-high opened this issue Sep 13, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@Desiki-high
Copy link
Member

Desiki-high commented Sep 13, 2023 •
edited
Loading

See https://github.com/dragonflyoss/image-service/actions/runs/6166303071/job/16735638578.

It seems that nydusify check always failed with the influxdb zran image.

Screenshots (if applicable)

image
@Desiki-high Desiki-high added the bug Something isn't working label Sep 13, 2023
@imeoer
Copy link
Collaborator

imeoer commented Sep 22, 2023

@NehemiahMi will take a look, thanks!

@imeoer
Copy link
Collaborator

imeoer commented Oct 10, 2023

@NehemiahMi found maybe it's a chunk deduplication bug for zran image.

NehemiahMi pushed a commit to NehemiahMi/image-service that referenced this issue Oct 10, 2023
fix: dragonflyoss#1423 zran check fail, because validate_header zran_…
b045938 
…count > chunk_count

1. targz-ref jump deduplicate chunk, because zran hasn't duplication
2. targz-ref rebuild filesystem chunk need not map

Signed-off-by: 伏鸾 <[email protected]>
@NehemiahMi NehemiahMi mentioned this issue Oct 10, 2023
Open
6 tasks
NehemiahMi pushed a commit to NehemiahMi/image-service that referenced this issue Oct 10, 2023
fix: dragonflyoss#1423 zran check fail, because validate_header zran_…
9d42cb1 
…count > chunk_count

1. targz-ref jump deduplicate chunk, because zran hasn't duplication
2. targz-ref rebuild filesystem chunk need not map

Signed-off-by: 伏鸾 <[email protected]>
Desiki-high pushed a commit to NehemiahMi/image-service that referenced this issue Oct 27, 2023
@Desiki-high
fix: dragonflyoss#1423 zran check fail, because validate_header zran_…
4a252e4 
…count > chunk_count

1. targz-ref jump deduplicate chunk, because zran hasn't duplication
2. targz-ref rebuild filesystem chunk need not map

Signed-off-by: 伏鸾 <[email protected]>
@Desiki-high
Copy link
Member Author

@imeoer It seems #1437 fixed the verify error of zran, but the integration-test failed. Will the integration test work now?

@imeoer
Copy link
Collaborator

imeoer commented Oct 31, 2023 •
edited
Loading

@Desiki-high It's still not a complete fixup. the integration test will be removed in #1450.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imeoer @Desiki-high