Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] UnsafeAccessorAttribute non-generic support for field #88626

Merged
merged 35 commits into from
Jul 14, 2023

Conversation

fanyang-mono
Copy link
Member

Contributes to #86040

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of nits for the new test and static modifier check

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we're mostly focusing on nits now

@fanyang-mono
Copy link
Member Author

The newly added tests for checking static modifier failed on CoreCLR. Disabled the test and created an issue(#88858) to track that.

@fanyang-mono
Copy link
Member Author

The newly added tests for checking static modifier failed on CoreCLR. Disabled the test and created an issue(#88858) to track that.

Aaron updated the test, it is passing now.

@AaronRobinsonMSFT
Copy link
Member

The failures all appear to be known - #88867 and #82637.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 45db21d into dotnet:main Jul 14, 2023
143 of 151 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants