Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreCLR] UnsafeAccessorAttribute: Missing static modifier check for field #88858

Closed
fanyang-mono opened this issue Jul 13, 2023 · 2 comments
Closed

[CoreCLR] UnsafeAccessorAttribute: Missing static modifier check for field #88858

fanyang-mono opened this issue Jul 13, 2023 · 2 comments
Assignees
@AaronRobinsonMSFT
Labels
area-VM-coreclr disabled-test The test is disabled in source code against the issue
Milestone
8.0.0

Comments

@fanyang-mono
Copy link
Member

CoreCLR missed the check for when UnsafeAccessorKind is set to Field, the corresponding field shouldn't be static and vice/versa.

A new testcase was added in #88626 and it failed on CoreCLR.

Re-enable test: Verify_InvalidTargetUnsafeAccessor upon fixing this issue.
@fanyang-mono fanyang-mono added disabled-test The test is disabled in source code against the issue area-VM-coreclr labels Jul 13, 2023
@fanyang-mono fanyang-mono added this to the 8.0.0 milestone Jul 13, 2023
@fanyang-mono fanyang-mono mentioned this issue Jul 13, 2023
Merged
@AaronRobinsonMSFT
Copy link
Member

I believe this is an issue in the newly added test. See https://github.com/dotnet/runtime/pull/88626/files#r1262953624

@AaronRobinsonMSFT
Copy link
Member

Closing based on #88626 (comment)

@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-VM-coreclr disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
2 participants
@AaronRobinsonMSFT @fanyang-mono