-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
114 tests are failing on gpu machine #115
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ae9ea59
Add test to find Ocelot conversion device issue
jank324 ba905f4
Fix tests on CPU-only machine
jank324 8469d89
Add test to check that torch to method works
jank324 7f4cbb5
Fix formatting
jank324 9e0db2e
Remove element device property
jank324 cc206e0
Fix how types and devices are handled
jank324 ba5fcc6
Fix tests failing on GPU machine
jank324 6805817
Fix formatting
jank324 4223bcf
Update changelog
jank324 02b0469
Add convenient device and dtype args to Ocelot import
jank324 ff9c409
Fix screen extent computation return type
jank324 cc763d7
Add test for float64 tracking; Remove some large rtol in tests
cr-xu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth mentioning explicitly in the documentation that it actually changes the behaviour of element creation, i.e. one can now create elements conveniently as before
v.6.0
, without the requirement to wrap every parameter as tensor firstThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right, but I also think this should be tested before making that claim.