Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

114 tests are failing on gpu machine #115

Merged
merged 12 commits into from
Dec 19, 2023
Merged

114 tests are failing on gpu machine #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ae9ea59
Add test to find Ocelot conversion device issue
jank324 Dec 11, 2023
ba905f4
Fix tests on CPU-only machine
jank324 Dec 11, 2023
8469d89
Add test to check that torch to method works
jank324 Dec 11, 2023
7f4cbb5
Fix formatting
jank324 Dec 11, 2023
9e0db2e
Remove element device property
jank324 Dec 11, 2023
cc206e0
Fix how types and devices are handled
jank324 Dec 11, 2023
ba5fcc6
Fix tests failing on GPU machine
jank324 Dec 11, 2023
6805817
Fix formatting
jank324 Dec 11, 2023
4223bcf
Update changelog
jank324 Dec 11, 2023
02b0469
Add convenient device and dtype args to Ocelot import
jank324 Dec 11, 2023
ff9c409
Fix screen extent computation return type
jank324 Dec 11, 2023
cc763d7
Add test for float64 tracking; Remove some large rtol in tests
cr-xu Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### 🚨 Breaking Changes

None
- The handling of `device` and `dtype` was overhauled. They might not behave as expected. `Element`s also no longer have a `device` attribute. (see #115) (@jank324)

Comment on lines +7 to 8
Copy link
Member

@cr-xu cr-xu Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth mentioning explicitly in the documentation that it actually changes the behaviour of element creation, i.e. one can now create elements conveniently as before v.6.0, without the requirement to wrap every parameter as tensor first

dipole = cheetah.Dipole(length=0.1, angle=0.1, dtype=torch.float32)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right, but I also think this should be tested before making that claim.

### 🚀 Features

Expand All @@ -15,7 +15,7 @@ None

- Fix the transfer maps in `Drift` and `Dipole`; Add R56 in horizontal and vertical correctors modelling (see #90) (@cr-xu)
- Fix fringe_field_exit of `Dipole` is overwritten by `fringe_field` bug (see #99) (@cr-xu)
- Fix error caused by mismatched devices on machines with CUDA GPUs (see #97) (@jank324)
- Fix error caused by mismatched devices on machines with CUDA GPUs (see #97 and #115) (@jank324)
- Fix error raised when tracking a `ParameterBeam` through an active `BPM` (see #101) (@jank324)
- Fix error in ASTRA beam import where the energy was set to `float64` instead of `float32` (see #111) (@jank324)
- Fix missing passing of `total_charge` in `ParameterBeam.transformed_to` (see #112) (@jank324)
Expand Down
Loading