Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UserEntity와 UserRepository 개발 #5
feat: UserEntity와 UserRepository 개발 #5
Changes from 4 commits
b1e9340
8591ca3
c420bce
f2ce63a
182a52a
d8704da
363a012
3929f39
9f573f2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인증 부분 밖으로 User 도메인쪽으로 빼기로 했었는데 혹시 안에 넣는게 나을까요?
혹시나 빼게된다면
JobCertificated
로 가면 좋을 것 같아요!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
유저 도메인 만들고 비슷한 필드들 묶다보니까 이렇게 묶인거 같은데! 저는 같이 있을때 자연스러워 보이는거 같아요
혹시, 분리되어야 하는 이유가 잘 기억이 안나서 한번 더 설명해주실 수 있나요? ㅠㅠ (진짜 기억안남)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넣어있는게 조금 자연스러워 보이긴하는데 JobStatus 는 어떻게 생각하세요!?!