feat: UserEntity와 UserRepository 개발 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devxb
changed the title
ddingmin
reviewed
Dec 26, 2023
ddingmin
reviewed
Dec 26, 2023
| @Column(name = "job_name") | ||
| private String name; | ||
|
|
||
| @Column(name = "certificated") |
There was a problem hiding this comment.
인증 부분 밖으로 User 도메인쪽으로 빼기로 했었는데 혹시 안에 넣는게 나을까요?
혹시나 빼게된다면 JobCertificated로 가면 좋을 것 같아요!
There was a problem hiding this comment.
유저 도메인 만들고 비슷한 필드들 묶다보니까 이렇게 묶인거 같은데! 저는 같이 있을때 자연스러워 보이는거 같아요
혹시, 분리되어야 하는 이유가 잘 기억이 안나서 한번 더 설명해주실 수 있나요? ㅠㅠ (진짜 기억안남)
There was a problem hiding this comment.
넣어있는게 조금 자연스러워 보이긴하는데 JobStatus 는 어떻게 생각하세요!?!
ddingmin
reviewed
Dec 26, 2023
ddingmin
reviewed
Dec 26, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 개발했나요?
user 도메인을 개발하고, 도메인간 통신 서비스 UserConnectorService를 구현했습니다.
🕶️ 어떻게 해결했나요?
🦀 이슈 넘버
(option) 어떤 부분에 집중하여 리뷰해야 할까요?
유저 Entity에 빠진게 있는지 봐주세요.
유저 Entity 관련해서 의문이 있으면 코멘트로 남겨주세요.
설정파일을 .properties나 .yml 뭐로할지 아직 안정한거 같은데, 정하고 나서 바꾸면 될거 같습니다. (저는 다 상관없어요~)