fix: Avatar Emissions brought back and roughness on scene fixed #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dalkia,
Ludmilafantaniella and
NickKhalow
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
anicalbano
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
🟢 Reviewed by QA on both Mac and Windows and seems to be working as expected.
A regression was made on other scenes that contain bright light emissions. Also the following points where checked:
- Backpack
- Emotes
- Map navigation
- Side bar navigation
- Teleport
- Auto-emote and music from scene
- Chat
27.09.2024_13.51.45_REC.mp4
m3taphysics
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatar emissions are brought back, but shouldn't cause areas to glow when they shouldn't and smoothness fix on scene shader, as recognised in the play test, where some things were super shiney and sparkly when they shouldn't be.