Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Terrain cache local handling #2206

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

dalkia
Copy link
Collaborator

@dalkia dalkia commented Sep 27, 2024

What does this PR change?

Corrected the way we store and delete the local cache, since the new version was prone to failure when the checksum was not the one that was stored

How to test the changes?

  1. Delete all local terrain files
  2. Enter the client and see the terrain. Explore the borders as well
  3. Reset the client and repeat step 2. You are looking to the cached terrain now, everything should be the same.
  4. Get out and delete only the terrain_cache_dictionaries folder
  5. Repeat step 2
  6. Get out and delete the terrain cache file
  7. Repeat step 2
  8. Repeat one last time step 2 to see once again the cached terrain

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copy link

github-actions bot commented Sep 27, 2024

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 70949e5
Logs https://github.com/decentraland/unity-explorer/actions/runs/11075306576
Download Windows https://github.com/decentraland/unity-explorer/suites/28944240873/artifacts/1988838340
Download Mac https://github.com/decentraland/unity-explorer/suites/28944240873/artifacts/1988822245
Built on 2024-09-27T18:26:04Z

@anicalbano anicalbano self-requested a review September 27, 2024 11:25
@dalkia dalkia enabled auto-merge (squash) September 27, 2024 17:03
@dalkia dalkia enabled auto-merge (squash) September 27, 2024 18:47
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Reviewed by QA and working as expected!
This PR also include regressions for:

  • Backpack and wearables
  • Emotes
  • Teleport
  • Map and navigation
  • Avatar locomotion
  • Switching in between scenes with auto-dance and music
  • Badges and My Profile

capture_240927_154351
capture_240927_154316

27.09.2024_15.38.16_REC.mp4

@dalkia dalkia merged commit 06ddd30 into main Sep 27, 2024
6 checks passed
@dalkia dalkia deleted the fix/terrain-cache-local-handling branch September 27, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants