Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Terrain local cache still open when trying to delete #2230

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix: Terrain local cache still open when trying to delete #2230

merged 2 commits into from
Sep 30, 2024

Conversation

dalkia
Copy link
Collaborator

@dalkia dalkia commented Sep 30, 2024

What does this PR change?

The file stream was not correctly disposed when trying to delete the file. This PR resorts the code as needed

How to test the changes?

  1. Launch the explorer
  2. Do the steps in this PR

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 649f7c3
Logs https://github.com/decentraland/unity-explorer/actions/runs/11107170084
Download Windows https://github.com/decentraland/unity-explorer/suites/29018224913/artifacts/1995986685
Download Mac https://github.com/decentraland/unity-explorer/suites/29018224913/artifacts/1996282582
Built on 2024-09-30T15:33:48Z

@anicalbano anicalbano self-requested a review September 30, 2024 15:09
Ludmilafantaniella
Ludmilafantaniella approved these changes Sep 30, 2024
View reviewed changes
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Reviewed by QA and working as expected on both Windows and Mac!
This PR also include regressions for:

  • Backpack and wearables
  • Emotes
  • Teleport
  • Map and navigation
  • Avatar locomotion
  • Switching in between scenes with auto-dance and music
  • Badges and My Profile

@dalkia dalkia merged commit 8af6c0b into main Sep 30, 2024
6 checks passed
@dalkia dalkia deleted the fix/terrain-cache-delete-issue branch September 30, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m3taphysics m3taphysics m3taphysics approved these changes

@davidejensen davidejensen davidejensen approved these changes

@lorux0 lorux0 lorux0 approved these changes

@mikhail-dcl mikhail-dcl mikhail-dcl approved these changes

@anicalbano anicalbano anicalbano approved these changes

@Ludmilafantaniella Ludmilafantaniella Ludmilafantaniella approved these changes

@DafGreco DafGreco Awaiting requested review from DafGreco

Assignees

@dalkia dalkia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dalkia @m3taphysics @davidejensen @lorux0 @mikhail-dcl @anicalbano @Ludmilafantaniella