Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix library_private_types_in_public_api overreporting on enum constructor params #4533

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix library_private_types_in_public_api overreporting on enum constructor params #4533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/src/rules/library_private_types_in_public_api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ class Validator extends SimpleAstVisitor<void> {
if (name != null && Identifier.isPrivateName(name.lexeme)) {
return;
}
// Enum constructors are effectively private so don't visit their params.
if (node.parent is EnumDeclaration) return;

node.parameters.accept(this);
}

Expand Down
13 changes: 13 additions & 0 deletions test/rules/library_private_types_in_public_api_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,19 @@ enum E {
lint(75, 2),
]);
}

/// https://github.com/dart-lang/linter/issues/4470
test_enum_constructorParams() async {
await assertNoDiagnostics(r'''
class _O {
const _O();
}
enum E {
a(_O());
const E(_O o);
}
''');
}
}

@reflectiveTest
Expand Down