Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix library_private_types_in_public_api overreporting on enum constructor params #4533

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix library_private_types_in_public_api overreporting on enum constructor params #4533

merged 1 commit into from
Jul 5, 2023

Conversation

pq
Copy link
Member

@pq pq commented Jul 5, 2023

Fixes #4470

/cc @bwilkerson

@github-actions github-actions bot added the set-recommended Affects a rule in the recommended Dart rule set label Jul 5, 2023
@coveralls
Copy link

Coverage Status

coverage: 96.755%. remained the same when pulling 2fe321a on library_private_types_in_public_api_enumCons into d956046 on main.

@pq pq merged commit 8f468c1 into main Jul 5, 2023
6 checks passed
@pq pq deleted the library_private_types_in_public_api_enumCons branch July 5, 2023 16:58
@pq pq mentioned this pull request Jul 5, 2023
Merged
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
fix library_private_types_in_public_api overreporting on enum cons …
777f494 
…params (dart-lang/linter#4533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
set-recommended Affects a rule in the recommended Dart rule set
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

library_private_types_in_public_api should not be triggered on enum constructors
3 participants
@pq @coveralls @bwilkerson